Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR Locator - getTrigger #220

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jan 22, 2020

Check if any GET vars exist, or if static $db ResultsOnLoad is true. If so, display results.

closes #219

Check if any GET vars exist, or if static $db ResultsOnLoad is true. If so, display results.

closes dynamic#219
@jsirish jsirish requested a review from muskie9 January 22, 2020 01:55
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #220 into master will increase coverage by 11.94%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #220       +/-   ##
=============================================
+ Coverage     60.42%   72.36%   +11.94%     
- Complexity      105      106        +1     
=============================================
  Files             7        7               
  Lines           379      380        +1     
=============================================
+ Hits            229      275       +46     
+ Misses          150      105       -45
Flag Coverage Δ Complexity Δ
#php 72.36% <100%> (+11.94%) 106 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
src/pages/LocatorController.php 83.2% <100%> (+30.93%) 36 <0> (+1) ⬆️
src/pages/Locator.php 94.28% <100%> (+6.05%) 22 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de9005...757e460. Read the comment docs.

@jsirish jsirish changed the base branch from 3.1 to master January 29, 2020 22:23
@muskie9 muskie9 changed the base branch from master to 3 June 1, 2022 00:51
@muskie9 muskie9 self-requested a review June 1, 2022 00:54
@muskie9 muskie9 merged commit f8f63a2 into dynamic:3 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR LocatorController index() - remove getTrigger() check for loading Locations on page load
2 participants